[vlc-devel] [PATCH 1/3] decoder: fix forgotten vout error state

Thomas Guillem thomas at gllm.fr
Thu Dec 17 12:25:14 UTC 2020

On Thu, Dec 17, 2020, at 12:21, Rémi Denis-Courmont wrote:
> Le torstaina 17. joulukuuta 2020, 11.52.03 EET Thomas Guillem a écrit :
> > If the pool allocation fails or if the vout fails to start (via
> > input_resource_RequestVout()), an error is returned from
> > decoder_UpdateVideoFormat().
> That's incorrect. A pool shall not be allocated if the decoder manages 
> pictures itself. It's a big waste of memory. The pool needs to be allocated if 
> and *only* if the decoder invokes the video.buffer_new() calback.
> I do get it that that's a preexisting problem not introduced by this patch, 
> but it still does make this patch completley moot.

I did this patch because vout_Start() could fail. It's hard to see it in the diff but this case is handled too. I also handled the pool allocation error the same way, but it's more a side effect of my patch.

> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list