[vlc-devel] [PATCH 1/2] android: util: remove redundant strncmp

Alexandre Janniaux ajanni at videolabs.io
Fri Feb 7 13:34:48 CET 2020


strcmp will already stop at the second string's length and the first
string is known to be null-terminated.
---
 modules/video_output/android/utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/video_output/android/utils.c b/modules/video_output/android/utils.c
index 1ca04e829c..40f81f1f99 100644
--- a/modules/video_output/android/utils.c
+++ b/modules/video_output/android/utils.c
@@ -546,8 +546,8 @@ AWindowHandler_new(vout_window_t *wnd, awh_events_t *p_events)
          */
         char *vout_modules = var_InheritString(wnd, "vout");
         if (vout_modules
-         && (strncmp(vout_modules, "gles2", sizeof("gles2") - 1) == 0
-          || strncmp(vout_modules, "opengles2", sizeof("opengles2") - 1) == 0))
+         && (strcmp(vout_modules, "gles2") == 0
+          || strcmp(vout_modules, "opengles2") == 0))
             p_awh->b_has_video_layout_listener = false;
         free(vout_modules);
     }
-- 
2.25.0



More information about the vlc-devel mailing list