[vlc-devel] [vlc-commits] Disable the libvgl plugin if OpenGL isn't available

[Steve Lhomme]

On 2020-02-11 11:01, Martin Storsjö wrote:
> vlc | branch: master | Martin Storsjö <martin at martin.st> | Tue Feb 11 11:59:11 2020 +0200| [9d9c70a52d6727f10ca82ecf74646f9a07f210f2] | committer: Martin Storsjö
> 
> Disable the libvgl plugin if OpenGL isn't available
> 
> This fixes building for Windows/ARM(64), which lacks OpenGL.

We should have a CI target for this. Is this properly supported by 
LLVM+mingw64 ?

> Previously, this plugin has compiled just fine without OpenGL available,
> but since b6a47686dfe2f789780f902b776e864e5c386ac5, OpenGL headers
> were included here. Just skip the plugin in those cases.

This is no longer included since 
32cb18379883d504750f7bc59939a0f05f49ecb5. But the patch makes sense 
nonetheless.

>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9d9c70a52d6727f10ca82ecf74646f9a07f210f2
> ---
> 
>   modules/video_output/Makefile.am | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/modules/video_output/Makefile.am b/modules/video_output/Makefile.am
> index 6bccecf006..4b1ac77747 100644
> --- a/modules/video_output/Makefile.am
> +++ b/modules/video_output/Makefile.am
> @@ -342,5 +342,8 @@ vout_LTLIBRARIES += \
>   	libvmem_plugin.la \
>   	libwdummy_plugin.la \
>   	libwextern_plugin.la \
> -	libvgl_plugin.la \
>   	libyuv_plugin.la
> +
> +if HAVE_GL
> +vout_LTLIBRARIES += libvgl_plugin.la
> +endif
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
>