[vlc-devel] [vlc-commits] Disable the libvgl plugin if OpenGL isn't available

[Martin Storsjö]

On Tue, 11 Feb 2020, Steve Lhomme wrote:

> On 2020-02-11 11:01, Martin Storsjö wrote:
>> vlc | branch: master | Martin Storsjö <martin at martin.st> | Tue Feb 11 
> 11:59:11 2020 +0200| [9d9c70a52d6727f10ca82ecf74646f9a07f210f2] | committer: 
> Martin Storsjö
>> 
>> Disable the libvgl plugin if OpenGL isn't available
>> 
>> This fixes building for Windows/ARM(64), which lacks OpenGL.
>
> We should have a CI target for this. Is this properly supported by 
> LLVM+mingw64 ?

Yes, it's supported by the llvm-mingw toolchain. Not sure if it's included 
in the proposed CI setup so far though.

>> Previously, this plugin has compiled just fine without OpenGL available,
>> but since b6a47686dfe2f789780f902b776e864e5c386ac5, OpenGL headers
>> were included here. Just skip the plugin in those cases.
>
> This is no longer included since 
> 32cb18379883d504750f7bc59939a0f05f49ecb5.

Oh, I hadn't noticed that one, my nightly build ran before that commit, 
and I tried fixing the build failure before fetching new commits. Yes with 
that one it should probably have worked again.

> But the patch makes sense nonetheless.

Yes, I presume there's not much use for this plugin in non-gl configs.

// Martin