[vlc-devel] [RFC PATCH 8/9] RFC: es_out: fix group_id and i_id collision

[Thomas Guillem]

I can add a little more contexts. I need to fully rework the libvlc player track selection API. I want to do only one time for good. For that, I need a way to identify a track with a string. The main usecase will be to able to save the user track selection preference on a db. 

The VLC CORE API use the ES pointer to identify the track. It is already used by our intfs. But this way to select a track is not straightforward and it is impossible to save  a track selection across several instance. 

On Wed, Feb 12, 2020, at 17:55, Rémi Denis-Courmont wrote:
> Le keskiviikkona 12. helmikuuta 2020, 16.43.26 EET Thomas Guillem a écrit :
> > A specified program (group > 0) is identified by its group id and by its
> > context pointer. The default program (group = 0) can be used by more than
> > one contexts.
> > 
> > An ES track is now identified by its i_id and by its context pointer. 
> 
> IMO the ES track should be referenced too, to prevent identifier aliasing 
> within a single input source with dynamic ES. i_id seems a lost cause with or 
> without the context pointer.

I think we can trust a single output source to give us unique ids. We could add a debug code to assert it and fix the buggy demuxers.

I'm affraid that referencing the ES track will make id not human readable (not sure if I understand what you said). 

> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel