[vlc-devel] [RFC PATCH 8/9] RFC: es_out: fix group_id and i_id collision

Rémi Denis-Courmont remi at remlab.net
Wed Feb 12 19:51:02 CET 2020


Le keskiviikkona 12. helmikuuta 2020, 20.39.02 EET Thomas Guillem a écrit :
> > IMO the ES track should be referenced too, to prevent identifier aliasing
> > within a single input source with dynamic ES. i_id seems a lost cause with
> > or without the context pointer.
> 
> I think we can trust a single output source to give us unique ids.

And I'm 100% sure that you can't trust that. If the source gives fixed IDs, 
nothing prevents it reusing them temporally, and it in fact will most likely 
happens with TS.

You simply can't base your design on such a broken assumption.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list