[vlc-devel] [RFC PATCH 8/9] RFC: es_out: fix group_id and i_id collision

[Rémi Denis-Courmont]

It's not a problem if you have a synchronous track selection API. But most likely you don't. Currently we only have an asynchronous one, and I can't see a practical way around that.

So the aliasing problem exists.

Le 13 février 2020 11:11:52 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Wed, Feb 12, 2020, at 19:51, Rémi Denis-Courmont wrote:
>> Le keskiviikkona 12. helmikuuta 2020, 20.39.02 EET Thomas Guillem a
>écrit :
>> > > IMO the ES track should be referenced too, to prevent identifier
>aliasing
>> > > within a single input source with dynamic ES. i_id seems a lost
>cause with
>> > > or without the context pointer.
>> > 
>> > I think we can trust a single output source to give us unique ids.
>> 
>> And I'm 100% sure that you can't trust that. If the source gives
>fixed IDs, 
>> nothing prevents it reusing them temporally, and it in fact will most
>likely 
>> happens with TS.
>> 
>> You simply can't base your design on such a broken assumption.
>
>For me, if a TS output different tracks with the same ID, they are
>outputted at different offset and not at the same time.
>Is my assumption correct ?
>If it's correct, I don't see any problem having the same identifier for
>2 different tracks having the same id at different offset of the file.
>
>If not, then I need to think about it.
>
>> 
>> -- 
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200213/d3099372/attachment.html>