[vlc-devel] [RFC PATCH 8/9] RFC: es_out: fix group_id and i_id collision

[Thomas Guillem]

On Wed, Feb 12, 2020, at 19:51, Rémi Denis-Courmont wrote:
> Le keskiviikkona 12. helmikuuta 2020, 20.39.02 EET Thomas Guillem a écrit :
> > > IMO the ES track should be referenced too, to prevent identifier aliasing
> > > within a single input source with dynamic ES. i_id seems a lost cause with
> > > or without the context pointer.
> > 
> > I think we can trust a single output source to give us unique ids.
> 
> And I'm 100% sure that you can't trust that. If the source gives fixed IDs, 
> nothing prevents it reusing them temporally, and it in fact will most likely 
> happens with TS.
> 
> You simply can't base your design on such a broken assumption.

For me, if a TS output different tracks with the same ID, they are outputted at different offset and not at the same time.
Is my assumption correct ?
If it's correct, I don't see any problem having the same identifier for 2 different tracks having the same id at different offset of the file.

If not, then I need to think about it.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel