[vlc-devel] [PATCH] apple: build: avoid configure if already done

[Steve Lhomme]

On 2020-02-13 22:43, Alexandre Janniaux wrote:
> On Thu, Feb 13, 2020 at 10:52:13PM +0200, Rémi Denis-Courmont wrote:
>> Le torstaina 13. helmikuuta 2020, 20.46.48 EET Alexandre Janniaux a écrit :
>>> Hi,
>>>
>>> Actually, it's iOS. I don't know how and how often you build
>>> for it but I use --config-cache locally and it takes 27 seconds
>>
>> 27 seconds is peanuts when configure needs to be rerun, as opposed to the time
>> it takes without caching.
> 
> I don't think new contributors should endorse this time, or
> the time to rewrite iOS build system.
> 
>>
>> The fact that you run configure everytime
> 
> Actually I don't, I have this patch.
> 
>> is a self-inflicted problem of using a
>> shell script instead of calling make directly. make anyway reruns configure, or
>> even autoconf, when needed.
> 
> Are you suggesting you would rewrite the build system for iOS?

Not really, a make.sh alongside the build.sh could do.

Most build systems have a configure.sh next to the build.sh so it can be 
run independently (and maybe other reasons).

If your make process needs many commands you could put them in a 
separate file.

Looking at the apple/build.sh it seems we could have a "static" target 
in the Makefile to do some of the common things static builds have to 
do. Then you just run "make static".

> Or maybe you have a better way to compile for it? Please share
> if so, it would be a better argument than telling me what I'm
> doing. I recall that you didn't care about this platform but
> maybe things have changed since that time.
> 
> I personnally can't spent that time and I'm just sharing what
> I did to workaround the issue.
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>