[vlc-devel] [3.x v2 1/4] vout/caopengllayer: remove HDR support

[Thomas Guillem]

LGTM for the set.

So, it's the new default vout for 3.0 ? It's kind of dangerous but we don't have any other choices I think.

Do you want me to test it before ?

Did you test (what we fail to do in one shot most of the time):
 - Spam play/stop
 - Play more than one videos with the same size
 - Play more than one videos with different size
 - Display off/log off then back on
 - With VT on/off, with cpu/hw filters on/off
 - Multiple video tracks ? With the mock for example.

On Thu, Feb 20, 2020, at 16:14, Marvin Scholz wrote:
> This is anyway not properly supported currently so opting in to it
> here does not change anything for the better.
> ---
>  modules/video_output/caopengllayer.m | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/modules/video_output/caopengllayer.m 
> b/modules/video_output/caopengllayer.m
> index a8cffadb61..133aab06f4 100644
> --- a/modules/video_output/caopengllayer.m
> +++ b/modules/video_output/caopengllayer.m
> @@ -43,8 +43,6 @@
>  
>  #include "opengl/vout_helper.h"
>  
> -#define OSX_SIERRA_AND_HIGHER (NSAppKitVersionNumber >= 1485)
> -
>  /*****************************************************************************
>   * Vout interface
>   *****************************************************************************/
> @@ -205,13 +203,6 @@ static int Open (vlc_object_t *p_this)
>          vd->display = PictureDisplay;
>          vd->control = Control;
>  
> -        if (OSX_SIERRA_AND_HIGHER) {
> -            /* request our screen's HDR mode (introduced in OS X 
> 10.11, but correctly supported in 10.12 only) */
> -            if ([sys->cgLayer 
> respondsToSelector:@selector(setWantsExtendedDynamicRangeContent:)]) {
> -                [sys->cgLayer setWantsExtendedDynamicRangeContent:YES];
> -            }
> -        }
> -
>          /* setup initial state */
>          CGSize outputSize;
>          if ([container 
> respondsToSelector:@selector(currentOutputSize)])
> -- 
> 2.21.1 (Apple Git-122.3)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel