[vlc-devel] [3.x v2 1/4] vout/caopengllayer: remove HDR support

[Marvin Scholz]

On 20 Feb 2020, at 17:29, Thomas Guillem wrote:

> LGTM for the set.
>
> So, it's the new default vout for 3.0 ? It's kind of dangerous but we 
> don't have any other choices I think.
Yes it is but the current one is very broken, so I am afraid we do not 
have much choice.
I only plan to enable it as default vout for macOS >= 10.14 and have it 
fallback to the
legacy macosx vout for older macOS versions (unless it is forced, of 
course).

I did not add the code for this yet as I did not want to put even more 
changes that
affect the other vout too into this patchset, so I will do the necessary 
changes for
that after this set is merged.

>
> Do you want me to test it before ?

Yes please!

>
> Did you test (what we fail to do in one shot most of the time):
>  - Spam play/stop
>  - Play more than one videos with the same size
I just now tested this and found an issue with it, will send
a new set later after some more testing, in case I find anything
else, and update my branch.

>  - Play more than one videos with different size
Tested and works fine

>  - Display off/log off then back on
Still need to test

>  - With VT on/off, with cpu/hw filters on/off
Tested and works fine

>  - Multiple video tracks ? With the mock for example.
Can you share the command again to do that?

>
> On Thu, Feb 20, 2020, at 16:14, Marvin Scholz wrote:
>> This is anyway not properly supported currently so opting in to it
>> here does not change anything for the better.
>> ---
>>  modules/video_output/caopengllayer.m | 9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/modules/video_output/caopengllayer.m
>> b/modules/video_output/caopengllayer.m
>> index a8cffadb61..133aab06f4 100644
>> --- a/modules/video_output/caopengllayer.m
>> +++ b/modules/video_output/caopengllayer.m
>> @@ -43,8 +43,6 @@
>>
>>  #include "opengl/vout_helper.h"
>>
>> -#define OSX_SIERRA_AND_HIGHER (NSAppKitVersionNumber >= 1485)
>> -
>>  /*****************************************************************************
>>   * Vout interface
>>   *****************************************************************************/
>> @@ -205,13 +203,6 @@ static int Open (vlc_object_t *p_this)
>>          vd->display = PictureDisplay;
>>          vd->control = Control;
>>
>> -        if (OSX_SIERRA_AND_HIGHER) {
>> -            /* request our screen's HDR mode (introduced in OS X
>> 10.11, but correctly supported in 10.12 only) */
>> -            if ([sys->cgLayer
>> respondsToSelector:@selector(setWantsExtendedDynamicRangeContent:)]) 
>> {
>> -                [sys->cgLayer 
>> setWantsExtendedDynamicRangeContent:YES];
>> -            }
>> -        }
>> -
>>          /* setup initial state */
>>          CGSize outputSize;
>>          if ([container
>> respondsToSelector:@selector(currentOutputSize)])
>> -- 
>> 2.21.1 (Apple Git-122.3)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel