[vlc-devel] [PATCH] Add module to submit listens to ListenBrainz

[Thomas Guillem]

You could but the common code in a common header and static inline for common

Anyway, 25% code duplication doesn't shock me.

On Sun, Feb 23, 2020, at 23:03, Kartik Ohri wrote:
> Most of the identical code concerns reading the metadata of audio file. I think around 150 lines could be taken out common. Thats 25% of the module codebase. 
> 
> On Mon, Feb 24, 2020, 3:18 AM Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> __
>> Depends, how much is in common, and how much is not?
>> 
>> On Sun, Feb 23, 2020, at 22:44, Kartik Ohri wrote:
>>> Yes, that is correct. Should I extract the common code in a utilities file and then have the modules depend on it ?
>>> 
>>> On Mon, Feb 24, 2020, 2:56 AM Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>>> 
>>>> 
>>>> On Sun, Feb 23, 2020, at 22:20, Kartik Ohrikartikohri13 at gmail.com wrote:
>>>> > VLC already has the audioscrobbler module to submit scrobbles to
>>>> > last.fm and other services with a similar API. This module extends
>>>> > that functionality to allow submission of listens to ListenBrainz.
>>>> > The existing audioscrobbler module is incompatible with ListenBrainz
>>>> > due to difference in authentication procedures and REST API for
>>>> > submissions.
>>>> 
>>>> But cannot you reuse some code of the other module?
>>>> 
>>>> 
>>>> -- 
>>>> Jean-Baptiste Kempf - President
>>>> +33 672 704 734
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> --
>> Jean-Baptiste Kempf - President
>> +33 672 704 734
>> 
>> 
>> 
>> _______________________________________________
>>  vlc-devel mailing list
>>  To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200224/1c84bb44/attachment.html>