[vlc-devel] [PATCH] compat: add clock_gettime, clock_nanosleep for darwin
epirat07 at gmail.com
Thu Feb 27 16:48:46 CET 2020
Hi, thanks for the review.
On 27 Feb 2020, at 16:27, Rémi Denis-Courmont wrote:
> - Using inline in a C file seems useless.
Ok, will remove that.
> - Testing for cancellation on error other than EINTR is suspicious.
Ah ok, I was a bit confused about that. I assumed that if a function
is a cancellation point it always needs to test for cancellation even
when returning an error?
> - Not sure LIBOBJ can be called conditionally.
I think it is, as its internally used by the VLC_REPLACE_DECL and the
AC_REPLACE_FUNCS macros, which call it conditionally.
(And we already do that in configure.ac for other OSes/systems)
> Le 27 février 2020 16:56:01 GMT+02:00, Marvin Scholz
> <epirat07 at gmail.com> a écrit :
More information about the vlc-devel