[vlc-devel] [PATCH] access: add gopher input module

[Francois Cartegnie]

Le 01/01/2020 à 11:50, Vincenzo Nicosia a écrit :

> + * Copyright (C) 2019 Vincenzo "KatolaZ" Nicosia
> + *
> + * Authors: Vincenzo "KatolaZ" Nicosia <katolaz at freaknet.org>
> + *
> + * This module was adapted from tcp.c

If you reuse code, then your header is wrong.

> +    set_capability( "access", 0 )
> +    set_shortname( N_( "gopher" ) )

Is there really a need for translation ?

> +    psz_path = malloc((strlen(url.psz_path) + 6) * sizeof(char));

I can think of funny things here with string max size, but you're saved
by the scheme/host length.

-- 
Francois Cartegnie
VideoLAN - VLC Developer