[vlc-devel] [PATCH] access: add gopher input submodule to tcp.c

[Vincenzo Nicosia]

On Tue, Jan 07, 2020 at 08:27:17AM +0100, Steve Lhomme wrote:
> Hi,
> 

[cut]

> > +
> > +    if (url.i_port <= 0){
> 
> I don't think the unsigned i_port can be negative. Testing against 0 should
> be enough.
>

right.

> Also nitpicking, add a space before the {
>

It looks like no specific coding style is enforced any more, right? :)
However, I understand that it makes sense to have a consistent coding
style in the same file. I will adapt the patch to match the style used
in tcp.c then.

[cut]

> > +        msg_Info(access, "path set to root resource");
> 
> INFO is the highest level of error and might prompt the user. You probably
> want a msg_Warn here.
>

OK.

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200107/6bac38fe/attachment.sig>