[vlc-devel] [PATCH] access: add gopher input submodule to tcp.c

[Steve Lhomme]

On 2020-01-07 8:37, Vincenzo Nicosia wrote:
> On Tue, Jan 07, 2020 at 08:27:17AM +0100, Steve Lhomme wrote:
>> Hi,
>>
> 
> [cut]
> 
>>> +
>>> +    if (url.i_port <= 0){
>>
>> I don't think the unsigned i_port can be negative. Testing against 0 should
>> be enough.
>>
> 
> right.
> 
>> Also nitpicking, add a space before the {
>>
> 
> It looks like no specific coding style is enforced any more, right? :)

Correct

> However, I understand that it makes sense to have a consistent coding
> style in the same file. I will adapt the patch to match the style used
> in tcp.c then.

That's the idea, we usually try to follow the style of the existing file 
for additions. For new code, especially modules, it depends on the 
author. But in general we use a space before the { of a if().

> [cut]
> 
>>> +        msg_Info(access, "path set to root resource");
>>
>> INFO is the highest level of error and might prompt the user. You probably
>> want a msg_Warn here.
>>
> 
> OK.
> 
> Thanks
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>