[vlc-devel] [PATCH] amem: fix integer overflow above 262143Hz

[Farid HAMMANE]

Hello Jean-Basptite,

Thank you for your review.

I agree that the number of channels grows in audio
systems. If there is no other reason except to save
space by sharing 32bits, I can declare them
as in audio_sample_format_t, i.e. an unsigned int
for the frequency and an uint16_t for the number of
channels. Is it ok for you ?

Note that as I wrote in the commit message, amem
currently does not support more than 8 channels

Best regards
Farid

On Tue, Jan 7, 2020 at 1:14 AM Jean-Baptiste Kempf <jb at videolan.org> wrote:

> Hello,
>
> On Tue, Jan 7, 2020, at 01:10, Farid Hammane wrote:
> > Today, the maximum value allowed for the sample rate
> > is 384000. 19 bits would be enough. The maximum value
> > allowed for the number of channels is 8. 4 bits are enough.
>
> We currently support more than 8 channels in the core.
> Planning for 16 seems a minimum, IMHO.
>
>
> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200107/d6bcd9df/attachment.html>