[vlc-devel] [PATCH] amem: fix integer overflow above 262143Hz
jb at videolan.org
Tue Jan 7 11:00:27 CET 2020
It is just that we currently have samples with 18 channels and some with ambisonic HOA 3rd channel (16channels).
Object-based will grow to 64 channels.
I would suggest to cut with channels at 10 and the rest for the rate.
On Tue, Jan 7, 2020, at 09:12, Farid HAMMANE wrote:
> Hello Jean-Basptite,
> Thank you for your review.
> I agree that the number of channels grows in audio
> systems. If there is no other reason except to save
> space by sharing 32bits, I can declare them
> as in audio_sample_format_t, i.e. an unsigned int
> for the frequency and an uint16_t for the number of
> channels. Is it ok for you ?
> Note that as I wrote in the commit message, amem
> currently does not support more than 8 channels
> Best regards
> On Tue, Jan 7, 2020 at 1:14 AM Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> On Tue, Jan 7, 2020, at 01:10, Farid Hammane wrote:
>> > Today, the maximum value allowed for the sample rate
>> > is 384000. 19 bits would be enough. The maximum value
>> > allowed for the number of channels is 8. 4 bits are enough.
>> We currently support more than 8 channels in the core.
>> Planning for 16 seems a minimum, IMHO.
>> Jean-Baptiste Kempf - President
>> +33 672 704 734
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
Jean-Baptiste Kempf - President
+33 672 704 734
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel