[vlc-devel] [PATCH] vout: Update vlc_player_vout_SetVar to fix fullscreen toggle hotkey

[Thomas Guillem]

On Fri, Jan 10, 2020, at 16:36, Akshay V wrote:
> 
> 
> On Fri, Jan 10, 2020 at 5:43 PM Thomas Guillem <thomas at gllm.fr> wrote:
>> __
>> Alexandre, ideally we would like to avoid variables to control vouts, but it's not done yet.
>> So, in the meantime we should continue to use variables.
>> 
>> Akshay, you spotted the problem, about the vout/player var_Set mismatch. I think the correct way to fix this issue is to fix the vlc_player_vout_IsFullscreen() function. This function should return the state of the first vout (via vlc_player_vout_Hold()) instead of the player state.
>> Same for vlc_player_vout_IsWallpaperModeEnabled().
>> 
>> You could also remove
>> 
>>  /* vout variables */
>>  VAR_CREATE("fullscreen", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
>>  VAR_CREATE("video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
>>  VAR_CREATE("video-wallpaper", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
>> 
>> in src/player/player.c
>> 
> should the removal of the vout variables and the updating the functions be in a single commit or not and if in two commits should this be in a single patch file?

You should do it in 2 commit into 2 separate patches.

> 
> -- 
> Regards,
> Akshay V
> GitHub <http://github.com/akshayaky> | Amrita Vishwa Vidyapeetham
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200110/0248e54a/attachment.html>