[vlc-devel] [PATCH 0/7] Refactor OpenGL fragment shaders

[Alexandre Janniaux]

LGTM, I only have nitpicks for commits and future bugs.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Jan 23, 2020 at 10:30:03AM +0100, Thomas Guillem wrote:
> LGTM for the set.
> Alexandre, what do you think ?
>
> On Wed, Jan 22, 2020, at 13:33, Romain Vimont wrote:
> > Here are some changes intended to simplify the logic to compute chroma
> > conversion in fragment shaders.
> >
> > Romain Vimont (7):
> >   opengl: explicitly set swizzle_per_tex values
> >   opengl: apply chroma conversion using a matrix
> >   opengl: generate chroma conversion matrices
> >   opengl: refactor color range for 2-bytes pixels
> >   opengl: avoid intermediate transpose step
> >   opengl: rename yuv_coefficients to conv_matrix
> >   opengl: apply swap U/V components via conv matrix
> >
> >  modules/video_output/opengl/converter.h       |   4 +-
> >  .../video_output/opengl/fragment_shaders.c    | 269 +++++++++++-------
> >  2 files changed, 174 insertions(+), 99 deletions(-)
> >
> > --
> > 2.25.0
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel