[vlc-devel] [PATCH 2/2] input: es_out: differentiate decoded & source audio formats

[Rémi Denis-Courmont]

Le maanantaina 27. tammikuuta 2020, 16.17.31 EET Francois Cartegnie a écrit :
> Because users can't get it. Too many invalid bugs.
> ---
>  src/input/es_out.c | 47 +++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 36 insertions(+), 11 deletions(-)
> 
> diff --git a/src/input/es_out.c b/src/input/es_out.c
> index 2a8dd6ce8d..df4bd89f84 100644
> --- a/src/input/es_out.c
> +++ b/src/input/es_out.c
> @@ -3802,22 +3802,47 @@ static void EsOutUpdateInfo( es_out_t *out,
> es_out_id_t *es, const vlc_meta_t *p case AUDIO_ES:
>          info_category_AddInfo( p_cat, _("Type"), _("Audio") );
> 
> -        if( fmt->audio.i_physical_channels )
> +        if( p_fmt_es->audio.i_physical_channels )
>              info_category_AddInfo( p_cat, _("Channels"), "%s",
> -                vlc_gettext( aout_FormatPrintChannels( &fmt->audio ) ) );
> +                vlc_gettext( aout_FormatPrintChannels( &p_fmt_es->audio ) )

Looks somewhat suspicious. Decoder should know better (or no worse) what the 
physical channels are than demuxer.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/