[vlc-devel] [PATCH 2/2] input: es_out: differentiate decoded & source audio formats

Francois Cartegnie fcvlcdev at free.fr
Mon Jan 27 17:41:02 CET 2020


Le 27/01/2020 à 17:30, Rémi Denis-Courmont a écrit :

>> -        if( fmt->audio.i_physical_channels )
>> +        if( p_fmt_es->audio.i_physical_channels )
>>              info_category_AddInfo( p_cat, _("Channels"), "%s",
>> -                vlc_gettext( aout_FormatPrintChannels( &fmt->audio ) ) );
>> +                vlc_gettext( aout_FormatPrintChannels( &p_fmt_es->audio ) )
> 
> Looks somewhat suspicious. Decoder should know better (or no worse) what the 
> physical channels are than demuxer.

Not if the decoder only plays a downgraded stream (A52/AAC/...)

-- 
Francois Cartegnie
VideoLAN - VLC Developer


More information about the vlc-devel mailing list