[vlc-devel] [PATCH 2/2] input: es_out: differentiate decoded & source audio formats

[Thomas Guillem]

On Mon, Jan 27, 2020, at 17:41, Francois Cartegnie wrote:
> Le 27/01/2020 à 17:30, Rémi Denis-Courmont a écrit :
> 
> >> -        if( fmt->audio.i_physical_channels )
> >> +        if( p_fmt_es->audio.i_physical_channels )
> >>              info_category_AddInfo( p_cat, _("Channels"), "%s",
> >> -                vlc_gettext( aout_FormatPrintChannels( &fmt->audio ) ) );
> >> +                vlc_gettext( aout_FormatPrintChannels( &p_fmt_es->audio ) )
> > 
> > Looks somewhat suspicious. Decoder should know better (or no worse) what the 
> > physical channels are than demuxer.
> 
> Not if the decoder only plays a downgraded stream (A52/AAC/...)

And DTS. The decoder could play only the core part, not the -HD part. In that case, the user won't know it's a DTS-HD stream.

Agree with François, we should display both.

> 
> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel