[vlc-devel] [PATCH 06/10] vout: control: do not wait until the deadline for incoming commands

Rémi Denis-Courmont remi at remlab.net
Fri Jul 17 15:56:24 CEST 2020


Le perjantaina 17. heinäkuuta 2020, 14.50.49 EEST Steve Lhomme a écrit :
> Either there are pending commands (filters and mouse handling) and we apply
> them before processing the next picture. Or there is none and they will be
> handled with the next frame.

The deadline served effectively two purposes:
- prioritise blitting over handling control requests,
- pace the thread loop.

I can guess from the commit message that you want to remove the priority 
corner-case (and I don't have any strong opinion on that). But there should be 
some modicum of explanation how pacing works from thereon.

Patches 1-5 look ok, though the control loop is a dying horse being beat.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list