[vlc-devel] [PATCH 06/10] vout: control: do not wait until the deadline for incoming commands

[Steve Lhomme]

On 2020-07-17 15:56, Rémi Denis-Courmont wrote:
> Le perjantaina 17. heinäkuuta 2020, 14.50.49 EEST Steve Lhomme a écrit :
>> Either there are pending commands (filters and mouse handling) and we apply
>> them before processing the next picture. Or there is none and they will be
>> handled with the next frame.
> 
> The deadline served effectively two purposes:
> - prioritise blitting over handling control requests,
> - pace the thread loop.
> 
> I can guess from the commit message that you want to remove the priority
> corner-case (and I don't have any strong opinion on that). But there should be
> some modicum of explanation how pacing works from thereon.

The pacing is done here:
https://code.videolan.org/videolan/vlc/-/blob/master/src/video_output/video_output.c#L1395

There is still a deadline that forces a wait when the frame is early. If 
it's not early (ie late) then there's no pacing and we continue pushing 
as fast as we can.

There is a drop mechanism if we try to display a late frame and the next 
one is ready to be used and will likely be late as well:

https://code.videolan.org/videolan/vlc/-/blob/master/src/video_output/video_output.c#L1460

> Patches 1-5 look ok, though the control loop is a dying horse being beat.
> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>