[vlc-devel] [PATCH 06/10] vout: control: do not wait until the deadline for incoming commands

[Rémi Denis-Courmont]

Le perjantaina 17. heinäkuuta 2020, 17.04.34 EEST Steve Lhomme a écrit :
> On 2020-07-17 15:56, Rémi Denis-Courmont wrote:
> > Le perjantaina 17. heinäkuuta 2020, 14.50.49 EEST Steve Lhomme a écrit :
> >> Either there are pending commands (filters and mouse handling) and we
> >> apply
> >> them before processing the next picture. Or there is none and they will
> >> be
> >> handled with the next frame.
> > 
> > The deadline served effectively two purposes:
> > - prioritise blitting over handling control requests,
> > - pace the thread loop.
> > 
> > I can guess from the commit message that you want to remove the priority
> > corner-case (and I don't have any strong opinion on that). But there
> > should be some modicum of explanation how pacing works from thereon.
> 
> The pacing is done here:
> https://code.videolan.org/videolan/vlc/-/blob/master/src/video_output/video_
> output.c#L1395

Sorry, my point was that the commit message should provide the modicum, not 
that I need the modicum myself.

I'm fine with the series otherwise.


-- 
Реми Дёни-Курмон
http://www.remlab.net/