[vlc-devel] [PATCH] stream_ReadLine: increase line length limit

Rémi Denis-Courmont remi at remlab.net
Thu Jul 23 15:35:48 CEST 2020


Le torstaina 23. heinäkuuta 2020, 10.29.33 EEST Romain Vimont a écrit :
> What about adding an explicit max_len parameter:
>     char *vlc_stream_ReadLine(stream_t *s, size_t max_len)
> to replace the hardcoded one?
> 
> (or in a separate function, that would be called by the current
> vlc_stream_ReadLine() with the hardcoded value)
> 
> The expected line limit may depend on the context.

Unfortunately, the practical limit depends on a lot of factors, most notably 
the final "consumer" rather than the caller, e.g. the GUI showing a property of 
an input item extracted from a playlist file.

And we don't want 23 different arbitrary limits.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list