[vlc-devel] [PATCH] vout_subpictures: fix scaled subpictures

Steve Lhomme robux4 at ycbcr.xyz
Tue Jul 28 16:29:09 CEST 2020


The horizontal/vertical values are inverted.
scale.h means "scale height", not "scale horizontal".
---
 src/video_output/vout_subpictures.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/video_output/vout_subpictures.c b/src/video_output/vout_subpictures.c
index 4c375e023d0..8766e7b5820 100644
--- a/src/video_output/vout_subpictures.c
+++ b/src/video_output/vout_subpictures.c
@@ -1246,13 +1246,13 @@ static subpicture_t *SpuRenderSubpictures(spu_t *spu,
                 {
                     if (scale.h != SCALE_UNIT)
                     {
-                        (*output_last_ptr)->zoom_h.num = scale.h;
-                        (*output_last_ptr)->zoom_h.den = SCALE_UNIT;
+                        (*output_last_ptr)->zoom_v.num = scale.h;
+                        (*output_last_ptr)->zoom_v.den = SCALE_UNIT;
                     }
                     if (scale.w != SCALE_UNIT)
                     {
-                        (*output_last_ptr)->zoom_v.num = scale.w;
-                        (*output_last_ptr)->zoom_v.den = SCALE_UNIT;
+                        (*output_last_ptr)->zoom_h.num = scale.w;
+                        (*output_last_ptr)->zoom_h.den = SCALE_UNIT;
                     }
                 }
 
-- 
2.26.2



More information about the vlc-devel mailing list