[vlc-devel] [PATCH 06/19] picture: use picture_DestroyDummy for picture_NewFromFormat() with no planes

Rémi Denis-Courmont remi at remlab.net
Thu Jul 30 17:50:21 CEST 2020

Le torstaina 30. heinäkuuta 2020, 15.16.47 EEST Steve Lhomme a écrit :
> No need to set the gc to some values and then change it later. We don't need
> to reset the opaque and p_sys, we just need to use picture_DestroyDummy
> when we know.
> We keep setting p_sys to NULL for compatibility.
> No need to pass a value in the gc.opaque as we don't use it, even for
> picture_DestroyFromFormat.

DestroyDummy implies that it's not doing the destruction. Pictures allocated 
by format certainly need resources destroyed. At the very least, I have a 
problem with the naming here.


More information about the vlc-devel mailing list