[vlc-devel] [PATCH 06/19] picture: use picture_DestroyDummy for picture_NewFromFormat() with no planes

Steve Lhomme robux4 at ycbcr.xyz
Fri Jul 31 06:25:24 CEST 2020

On 2020-07-30 17:50, Rémi Denis-Courmont wrote:
> Le torstaina 30. heinäkuuta 2020, 15.16.47 EEST Steve Lhomme a écrit :
>> No need to set the gc to some values and then change it later. We don't need
>> to reset the opaque and p_sys, we just need to use picture_DestroyDummy
>> when we know.
>> We keep setting p_sys to NULL for compatibility.
>> No need to pass a value in the gc.opaque as we don't use it, even for
>> picture_DestroyFromFormat.
> DestroyDummy implies that it's not doing the destruction. Pictures allocated
> by format certainly need resources destroyed. At the very least, I have a
> problem with the naming here.

I used the function that's already there to do exactly what is needed 
(nothing). This is the case for pictures with no planes, therefore there 
is nothing to be destroyed. picture_Allocate() was never called.

In any case that's just transition code. picture_DestroyDummy() is 
removed in 7/19.

More information about the vlc-devel mailing list