[vlc-devel] [PATCH] opengl: interop_cvpx: remove TRANSFORM_VFLIP

Alexandre Janniaux ajanni at videolabs.io
Sun Jun 28 22:56:36 CEST 2020


The picture is never upside-down neither on iOS nor MacOSX, and neither
when being output from Videotoolbox nor when a CVPixelBuffer is used as
a rendering target by OpenGL.
---
 modules/video_output/opengl/interop_cvpx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/video_output/opengl/interop_cvpx.c b/modules/video_output/opengl/interop_cvpx.c
index cf8b23cd239..92efde1859a 100644
--- a/modules/video_output/opengl/interop_cvpx.c
+++ b/modules/video_output/opengl/interop_cvpx.c
@@ -173,9 +173,6 @@ Open(vlc_object_t *obj)
      && interop->fmt_in.i_chroma != VLC_CODEC_CVPX_P010)
         return VLC_EGENERIC;
 
-    /* The pictures are uploaded upside-down */
-    video_format_TransformBy(&interop->fmt_out, TRANSFORM_VFLIP);
-
     struct priv *priv = calloc(1, sizeof(struct priv));
     if (unlikely(priv == NULL))
         return VLC_ENOMEM;
-- 
2.27.0



More information about the vlc-devel mailing list