[vlc-devel] [PATCH] opengl: interop_cvpx: remove TRANSFORM_VFLIP

[Romain Vimont]

On Sun, Jun 28, 2020 at 10:56:36PM +0200, Alexandre Janniaux wrote:
> The picture is never upside-down neither on iOS nor MacOSX, and neither
> when being output from Videotoolbox nor when a CVPixelBuffer is used as
> a rendering target by OpenGL.

It is upside-down, but the vflip was applied twice:
https://mailman.videolan.org/pipermail/vlc-devel/2020-June/134888.html

Regards

> ---
>  modules/video_output/opengl/interop_cvpx.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/modules/video_output/opengl/interop_cvpx.c b/modules/video_output/opengl/interop_cvpx.c
> index cf8b23cd239..92efde1859a 100644
> --- a/modules/video_output/opengl/interop_cvpx.c
> +++ b/modules/video_output/opengl/interop_cvpx.c
> @@ -173,9 +173,6 @@ Open(vlc_object_t *obj)
>       && interop->fmt_in.i_chroma != VLC_CODEC_CVPX_P010)
>          return VLC_EGENERIC;
>  
> -    /* The pictures are uploaded upside-down */
> -    video_format_TransformBy(&interop->fmt_out, TRANSFORM_VFLIP);
> -
>      struct priv *priv = calloc(1, sizeof(struct priv));
>      if (unlikely(priv == NULL))
>          return VLC_ENOMEM;
> -- 
> 2.27.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel