[vlc-devel] [PATCH] vlc: use HAVE_DAEMON to guard daemon specific code

[Rémi Denis-Courmont]

Le keskiviikkona 4. maaliskuuta 2020, 16.08.53 EET Marvin Scholz a écrit :
> ---
>  src/interface/interface.c | 2 +-
>  src/libvlc-module.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

IMO the code should be ripped out entirely, as I doubt anybody is using it.

And if somebody still wants this feature, then it's poorly implemented:
The caller has no way to know if the service was spawned succesfully, since 
VLC will return 0 regardless. And then the PID file is created asynchronously 
later, so you can't even look for it to know either.

Better do it correctly without daemon(), or even let init handle service 
management.

-- 
Rémi Denis-Courmont
http://www.remlab.net/