[vlc-devel] [PATCH] vlc: use HAVE_DAEMON to guard daemon specific code

[Marvin Scholz]

On 4 Mar 2020, at 16:12, Rémi Denis-Courmont wrote:

> Le keskiviikkona 4. maaliskuuta 2020, 16.08.53 EET Marvin Scholz a 
> écrit :
>> ---
>>  src/interface/interface.c | 2 +-
>>  src/libvlc-module.c       | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> IMO the code should be ripped out entirely, as I doubt anybody is 
> using it.
>

+1 for removing it, IMO. (for the same reason)

> And if somebody still wants this feature, then it's poorly 
> implemented:
> The caller has no way to know if the service was spawned succesfully, 
> since
> VLC will return 0 regardless. And then the PID file is created 
> asynchronously
> later, so you can't even look for it to know either.
>
> Better do it correctly without daemon(), or even let init handle 
> service
> management.
>
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel