[vlc-devel] [PATCH] Add module to submit listens to ListenBrainz.

[Kartik Ohri]

On Tue, Mar 17, 2020 at 12:22 AM Frederik “Freso” S. Olesen <
freso.dk at gmail.com> wrote:

> Den 08.03.2020 kl. 18.14 skrev Kartik Ohri:
> > +typedef struct listen_t
> > +{
> > +    char *psz_artist;
> > +    char *psz_title;
> > +    char *psz_album;
> > +    char *psz_track_number;
> > +    int i_length;
> > +    char *psz_musicbrainz_id;
>
> I would maybe call this `musicbrainz_recording_id` or something to this
> effect, to keep the option open for including and submitting more MBIDs
> in the future.
>
> I'll do that.

> > +    time_t date;
> > +} listen_t;
> […]
> > +    if ( !b_skip )
> > +    {
> > +        RETRIEVE_METADATA(p_sys->p_current_song.psz_album, Album);
> > +        RETRIEVE_METADATA(p_sys->p_current_song.psz_musicbrainz_id,
> TrackID);
>
> Is TrackID the VLC internal name for MB Recording IDs? So you can’t (or
> shouldn’t) change it here?
>
> Yes, it is.

> > +        RETRIEVE_METADATA(p_sys->p_current_song.psz_track_number,
> TrackNum);
> > +        p_sys->p_current_song.i_length = SEC_FROM_VLC_TICK
> (input_item_GetDuration (item));
> > +        msg_Dbg (p_this, "Meta data registered");
> > +        vlc_cond_signal (&p_sys->wait);
> > +    }
>
> --
> Solidarity,
> Frederik “Freso” S. Olesen <https://freso.dk/>
>
> Like what I do? Check out <https://www.patreon.com/Freso>!
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200317/ef6167c5/attachment.html>