[vlc-devel] [PATCH] d3d11va: remove unused function

Alexandre Janniaux ajanni at videolabs.io
Wed Mar 25 16:43:38 CET 2020


Thank you for clarifying, please discard this one then as
I don't have hardware to go further on fixing this for now.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Mar 25, 2020 at 04:37:51PM +0100, Steve Lhomme wrote:
> I intentionally kept it (with the warning) because we still need to handle
> this case (although maybe Qualcomm Windows machines don't have this issue
> anymore).
>
> On 2020-03-25 16:09, Alexandre Janniaux wrote:
> > Usage of CanUseDecoderPadding was removed with pull model in commit
> > 851a4d09d06ff0f6944142ca8d9e318c03c2da47.
> > ---
> >   modules/codec/avcodec/d3d11va.c | 7 -------
> >   1 file changed, 7 deletions(-)
> >
> > diff --git a/modules/codec/avcodec/d3d11va.c b/modules/codec/avcodec/d3d11va.c
> > index 9dc2e4bea3..dd34c58bfd 100644
> > --- a/modules/codec/avcodec/d3d11va.c
> > +++ b/modules/codec/avcodec/d3d11va.c
> > @@ -508,13 +508,6 @@ static int DxSetupOutput(vlc_va_t *va, const directx_va_mode_t *mode, const vide
> >       return VLC_EGENERIC;
> >   }
> > -static bool CanUseDecoderPadding(const vlc_va_sys_t *sys)
> > -{
> > -    /* Qualcomm hardware has issues with textures and pixels that should not be
> > -    * part of the decoded area */
> > -    return sys->d3d_dev->adapterDesc.VendorId != GPU_MANUFACTURER_QUALCOMM;
> > -}
> > -
> >   /**
> >    * It creates a Direct3D11 decoder using the given video format
> >    */
> > --
> > 2.26.0
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list