[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Rémi Denis-Courmont]

Le perjantaina 1. toukokuuta 2020, 20.31.39 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> On Fri, May 01, 2020 at 07:43:01PM +0300, Rémi Denis-Courmont wrote:
> > Le perjantaina 1. toukokuuta 2020, 17.17.10 EEST Marvin Scholz a écrit :
> > > On 1 May 2020, at 15:58, Alexandre Janniaux wrote:
> > > > I'll move the hook from contrib/bootstrap to the apple script,
> > > > if everyone agree.
> > > 
> > > I am fine with the way you did it in this patch.
> > 
> > This patch is contrary to the very design of the contrib system which is
> > meant to automatically adjust to the selected target, and not be tied to
> > specific OS versions/variants liek the previous systems were.
> 
> Are you ok with moving it to the build script?

I can live with it, but it's a bad idea.

There will be errors when switching to other versions, and it will eventually 
break completely when autoconf fixes the loop hole, or when contribs use 
something than autoconf.

-- 
Реми Дёни-Курмон
http://www.remlab.net/