[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Marvin Scholz]

On 1 May 2020, at 19:53, Rémi Denis-Courmont wrote:

> Le perjantaina 1. toukokuuta 2020, 20.31.39 EEST Alexandre Janniaux a 
> écrit :
>> Hi,
>>
>> On Fri, May 01, 2020 at 07:43:01PM +0300, Rémi Denis-Courmont wrote:
>>> Le perjantaina 1. toukokuuta 2020, 17.17.10 EEST Marvin Scholz a 
>>> écrit :
>>>> On 1 May 2020, at 15:58, Alexandre Janniaux wrote:
>>>>> I'll move the hook from contrib/bootstrap to the apple script,
>>>>> if everyone agree.
>>>>
>>>> I am fine with the way you did it in this patch.
>>>
>>> This patch is contrary to the very design of the contrib system 
>>> which is
>>> meant to automatically adjust to the selected target, and not be 
>>> tied to
>>> specific OS versions/variants liek the previous systems were.
>>
>> Are you ok with moving it to the build script?
>
> I can live with it, but it's a bad idea.
>
> There will be errors when switching to other versions, and it will 
> eventually
> break completely when autoconf fixes the loop hole, or when contribs 
> use
> something than autoconf.
>

I think there is some misunderstanding here.

The whole purpose of these hacks, as I already explained, is to 
workaround
the incorrect way autoconf does the checks. So of course it is specific 
to autoconf.

In general in addition to this we should set -Wpartial-availbaility as 
this will ensure
that even if build systems misdetect function availability it will fail 
compilation.
(And then needs patching of the failed contrib to work around the 
misdetection).

And the reason to have it in contribs proper is to not have to remember 
to run some
specific script to set these hack env variables before running the 
contrib make and
rely on a properly set up environment…

> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel