[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

Rémi Denis-Courmont remi at remlab.net
Fri May 1 21:19:05 CEST 2020


Le perjantaina 1. toukokuuta 2020, 21.13.14 EEST Marvin Scholz a écrit :
> The whole purpose of these hacks, as I already explained, is to
> workaround the incorrect way autoconf does the checks. So of course it is
> specific to autoconf.

There is nothing incorrect about autoconf *there* and nothing specific to 
autoconf either. If you ask autoconf to check for a symbol, it does so. The 
same is true of cmake or of bespoke configure scripts.

Sometimes, checking for symbols is wrong because a function or functional 
macro is not guaranteed to exists under the same name as a symbol. In that 
case, a proper code snippet compilation test is necessary. But failing that 
can only ever lead to false negatives, not false positives.

What's incorrect is the way you're building packages with automatic 
configuration (using autotools or otherwise). You are literaly not building 
those the way they're supposed to be built.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list