[vlc-devel] [PATCH 3/5] adaptive: PlaylistManager: remove useless mutex lock

Alexandre Janniaux ajanni at videolabs.io
Sun Nov 1 12:34:19 CET 2020


---
 modules/demux/adaptive/PlaylistManager.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/demux/adaptive/PlaylistManager.cpp b/modules/demux/adaptive/PlaylistManager.cpp
index 8344de005a..b00a691ccc 100644
--- a/modules/demux/adaptive/PlaylistManager.cpp
+++ b/modules/demux/adaptive/PlaylistManager.cpp
@@ -672,9 +672,9 @@ void PlaylistManager::Run()
             else /*if(i_return == AbstractStream::buffering_suspended)*/
                 i_deadline += VLC_TICK_FROM_MS(250);
 
-            vlc_mutex_lock(&demux.lock);
+            // TODO: The current function doesn't seem to modify shared
+            //       state under demux lock.
             vlc_cond_signal(&demux.cond);
-            vlc_mutex_unlock(&demux.lock);
 
             while(b_buffering &&
                     vlc_cond_timedwait(&waitcond, &lock, i_deadline) == 0 &&
-- 
2.29.2



More information about the vlc-devel mailing list