[vlc-devel] [PATCH 2/5] adaptive: PlaylistManager: fix spurious condition

Alexandre Janniaux ajanni at videolabs.io
Sun Nov 1 16:59:29 CET 2020


Hi,

Sure, that joins Zhao Zhili's point. Please discard this specific
patch from the patchset.

Regards,
--
Alexandre Janniaux
Videolabs

On Sun, Nov 01, 2020 at 03:43:28PM +0100, Francois Cartegnie wrote:
> Le 01/11/2020 à 12:34, Alexandre Janniaux a écrit :
>
> > -        if(!b_dead)
> > -            vlc_cond_timedwait(&demux.cond, &demux.lock, vlc_tick_now() + VLC_TICK_FROM_MS(50));
> > +        vlc_tick_t deadline = vlc_tick_now() + VLC_TICK_FROM_MS(50);
> > +        int i_ret = 0;
> > +        while(!b_dead && i_ret == 0)
> > +            i_ret = vlc_cond_timedwait(&demux.cond, &demux.lock, deadline);
> >           vlc_mutex_unlock(&demux.lock);
> >           return (b_dead || b_all_disabled) ? AbstractStream::status_eof : AbstractStream::status_buffering;
>
> As intended. spurious wake ups are acceptable at this place.
>
>
> --
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list