[vlc-devel] [PATCH] cli: fix line trimming with socket cli

[Rémi Denis-Courmont]

Le torstaina 5. marraskuuta 2020, 17.51.52 EET Romain Vimont a écrit :
> On Thu, Nov 05, 2020 at 05:30:02PM +0200, Rémi Denis-Courmont wrote:
> > Le torstaina 5. marraskuuta 2020, 16.20.58 EET Alexandre Janniaux a écrit 
:
> > > Hi,
> > > 
> > > In term of UX, it avoids this issue:
> > >     $ telnet 192.168.1.31 9999
> > 
> > And? RC/CLI is *not* implementing the Telnet protocol. telnet is not for
> > raw I/O. There's netcat et al for that.
> 
> I guess that netcat on Windows suffers from the same problem.

The point is that you cannot use a Telnet client. VLC RC sends and receives 
raw UTF-8; that is simply not compatible with Telnet in either direction. And 
Telnet clients don't support Unix sockets, which are the recommended access 
mean - for pretty damn obvious security reasons.

Windows has separate code for handling input, so I fail to see your point. If 
you want to patch the Windows code, help yourself.

-- 
Rémi Denis-Courmont
http://www.remlab.net/