[vlc-devel] [PATCH] cli: fix line trimming with socket cli

[Alexandre Janniaux]

Hi,

On Thu, Nov 05, 2020 at 06:06:31PM +0200, Rémi Denis-Courmont wrote:
> Le torstaina 5. marraskuuta 2020, 17.51.52 EET Romain Vimont a écrit :
> > On Thu, Nov 05, 2020 at 05:30:02PM +0200, Rémi Denis-Courmont wrote:
> > > Le torstaina 5. marraskuuta 2020, 16.20.58 EET Alexandre Janniaux a écrit
> :
> > > > Hi,
> > > >
> > > > In term of UX, it avoids this issue:
> > > >     $ telnet 192.168.1.31 9999
> > >
> > > And? RC/CLI is *not* implementing the Telnet protocol. telnet is not for
> > > raw I/O. There's netcat et al for that.
> >
> > I guess that netcat on Windows suffers from the same problem.
>
> The point is that you cannot use a Telnet client. VLC RC sends and receives
> raw UTF-8; that is simply not compatible with Telnet in either direction. And
> Telnet clients don't support Unix sockets, which are the recommended access
> mean - for pretty damn obvious security reasons.

Ok, though I'd have a hard time opening a unix socket on an
iOS device from my computer for obvious reasons. The history
of the project is quite unclear related to that too, given
tickets like https://trac.videolan.org/vlc/ticket/203 and
recent discussion with Pierre, and given it was working
before.

Please discard the patch.

Regards,
--
Alexandre Janniaux
Videolabs