[vlc-devel] [PATCH v2 3/3] contrib: libplacebo: depend on vulkan-loader for WIN32 builds

[Steve Lhomme]

On 2020-11-08 16:37, Alexandre Janniaux wrote:
> This enable libplacebo vulkan support, which is used by the vulkan video
> output.

It seems to only enable it for Windows. Shouldn't "vulkan-header 
$(DEPS_vulkan-header)" be done outside of the ifdef ?

> ---
>   contrib/src/libplacebo/rules.mak | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/src/libplacebo/rules.mak b/contrib/src/libplacebo/rules.mak
> index 1f34691824..6b808be615 100644
> --- a/contrib/src/libplacebo/rules.mak
> +++ b/contrib/src/libplacebo/rules.mak
> @@ -13,8 +13,10 @@ ifeq ($(call need_pkg,"libplacebo"),)
>   PKGS_FOUND += libplacebo
>   endif
>   
> -ifdef HAVE_WIN32
> +ifdef HAVE_WIN32_DESKTOP
>   DEPS_libplacebo += pthreads $(DEPS_pthreads)
> +# vulkan-loader is enabled only for win32 for now, for vulkan support
> +DEPS_libplacebo += vulkan-loader $(DEPS_vulkan-loader) vulkan-header $(DEPS_vulkan-header)
>   endif
>   
>   PLACEBOCONF := -Dglslang=enabled \
> -- 
> 2.29.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>