[vlc-devel] [PATCH v2 3/3] contrib: libplacebo: depend on vulkan-loader for WIN32 builds

[Alexandre Janniaux]

On Mon, Nov 09, 2020 at 08:13:52AM +0100, Steve Lhomme wrote:
> On 2020-11-08 16:37, Alexandre Janniaux wrote:
> > This enable libplacebo vulkan support, which is used by the vulkan video
> > output.
>
> It seems to only enable it for Windows. Shouldn't "vulkan-header
> $(DEPS_vulkan-header)" be done outside of the ifdef ?

I'm only enabling it for Windows yes. This is much harder
to make it work on other platforms currently.

> > ---
> >   contrib/src/libplacebo/rules.mak | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/contrib/src/libplacebo/rules.mak b/contrib/src/libplacebo/rules.mak
> > index 1f34691824..6b808be615 100644
> > --- a/contrib/src/libplacebo/rules.mak
> > +++ b/contrib/src/libplacebo/rules.mak
> > @@ -13,8 +13,10 @@ ifeq ($(call need_pkg,"libplacebo"),)
> >   PKGS_FOUND += libplacebo
> >   endif
> > -ifdef HAVE_WIN32
> > +ifdef HAVE_WIN32_DESKTOP
> >   DEPS_libplacebo += pthreads $(DEPS_pthreads)
> > +# vulkan-loader is enabled only for win32 for now, for vulkan support
> > +DEPS_libplacebo += vulkan-loader $(DEPS_vulkan-loader) vulkan-header $(DEPS_vulkan-header)
> >   endif
> >   PLACEBOCONF := -Dglslang=enabled \
> > --
> > 2.29.2
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel