[vlc-devel] [PATCH 3.0.x] macosx/build: fix compile on macOS 10.15.6

[David Fuhrmann]

> Am 11.11.2020 um 18:59 schrieb Marvin Scholz <epirat07 at gmail.com>:
> 
> 
> 
> On 11 Nov 2020, at 18:57, Zhao Zhili wrote:
> 
>> > On Nov 12, 2020, at 1:50 AM, Marvin Scholz <epirat07 at gmail.com> wrote:
>>> 
>>> 
>>> 
>>> On 11 Nov 2020, at 17:44, Felix Paul Kühne wrote:
>>> 
>>>> Hello,
>>>> 
>>>>> Am 10.11.2020 um 16:30 schrieb Zhao Zhili <quinkblack at foxmail.com>:
>>>>> 
>>>>> ---
>>>>> extras/package/macosx/build.sh | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>> 
>>>>> diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh
>>>>> index 4508354a9f..be5d449662 100755
>>>>> --- a/extras/package/macosx/build.sh
>>>>> +++ b/extras/package/macosx/build.sh
>>>>> @@ -10,7 +10,7 @@ info()
>>>>> 
>>>>> ARCH="x86_64"
>>>>> MINIMAL_OSX_VERSION="10.7"
>>>>> -OSX_VERSION=`xcrun --show-sdk-version`
>>>>> +OSX_VERSION=`xcrun --show-sdk-version |cut -d. -f1-2`
>>>>> OSX_KERNELVERSION=`uname -r | cut -d. -f1`
>>>>> SDKROOT=`xcode-select -print-path`/Platforms/MacOSX.platform/Developer/SDKs/MacOSX$OSX_VERSION.sdk
>>>>> VLCBUILDDIR=""
>>>>> —
>>>>> 2.28.0
>>>> 
>>>> 
>>>> LGTM and needs backport to 3.0.
>>>> 
>>> 
>>> LGTM from my side too, but shouldn't this be using  xcrun --show-sdk-path
>>> which seems much better approach than to try to manually put together a SDK path…
>> 
>> I'm not familiar about the build environment of macOS. Fill free to fix it cleanly
>> with a better approach.
>> 
> 
> Sure, I was not expecting you to fix this, just wanted to propose this and get opinions
> from Felix and maybe David who are more familiar with the build.sh script.

Yes, we are already using "xcrun --show-sdk-path“ in the master repo, this patch and the problem should be only there in 3.x.
For some reason, in 3.x OSX_VERSION environment variable is also still used and exported in the contrib system (not sure why, though).

We could backport the environment we have in vlc.git also to 3.x, but if we want to, maybe lets do it after the pending release.

BR. David



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201111/ba17aa02/attachment.html>