[vlc-devel] [vlc-commits] thread: add a function to give names to threads

[Rémi Denis-Courmont]

Le lundi 16 novembre 2020, 09:31:52 EET Steve Lhomme a écrit :
> On 2020-11-13 19:29, Rémi Denis-Courmont wrote:
> > WTF? This was rejected by two people for multiple reasons.
> 
> This was not rejected by two people.

Except it was.

> - Alexandre on calling pthread_setname_np because it's less code, well
> no they all have different signatures

Except they do. The prototype is the same on Android, glibc and NetBSD (and 
likely other OSes). Not that it even needs to be exactly compatible. And so 
at least one of Alexandre's objection remains unaddressed.

> - Alexandre on always truncating to 15, no need for extra string
> manipulation when we don't need to

As Alexandre already pointed out, that's irrelevant.

> - saying Android specific code is not specific to Android, contrary to
> what currently exists in master and what the latest Google code does and
> document (they don't truncate and reject anything bigger than 15, unlike
> Linux)

I also point out missing cast, failing to avoid ifdefs, and bypassing glibc.


And no, dav1d is NOT a valid rationale

-- 
Rémi Denis-Courmont