[vlc-devel] [PATCH 1/2] cli: remove TCP mode (--rc-host)

Rémi Denis-Courmont remi at remlab.net
Sat Nov 21 15:43:23 CET 2020


Le lauantaina 21. marraskuuta 2020, 12.43.34 EET Pierre Ynard via vlc-devel a 
écrit :
> The lua CLI handled multiple TCP clients fine. 

Not really. At first, I thought about handling multiple (Unix) clients. For 
requests/responses, it's trivial enough. But for event notifications, it's 
broken. If just one client gets congested, it will jam all other clients (and 
the VLC playlist state machine too).

In the case of local domain sockets, we can mostly neglect the problem because 
bandwidth, latency and loss are non-issues. That's how everything else does it 
- X11, Wayland, PulseAudio, D-Bus, etc. But for TCP, it's "problematic".

And AFAICT, the 3.0 Lua code instead fails to send notifications at all. 
Notably it ignores --rc-show-pos. It's one of those regressions that the Lua 
code never addressed.

So there you go...

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list