[vlc-devel] [PATCH 1/2] cli: remove TCP mode (--rc-host)

Rémi Denis-Courmont remi at remlab.net
Sat Nov 21 21:19:34 CET 2020


Le lauantaina 21. marraskuuta 2020, 16.43.23 EET Rémi Denis-Courmont a écrit :
> Le lauantaina 21. marraskuuta 2020, 12.43.34 EET Pierre Ynard via vlc-devel
> a
> écrit :
> > The lua CLI handled multiple TCP clients fine.
> 
> Not really. At first, I thought about handling multiple (Unix) clients. For
> requests/responses, it's trivial enough. But for event notifications, it's
> broken. If just one client gets congested, it will jam all other clients
> (and the VLC playlist state machine too).

My mistake. It's even worse than that.

The Lua code does handle output congestion by refusing to accept any new 
command until the output of the last one is sent. That would be very fine if 
there were no notifications: it won't actually jam the other clients. But it's 
all but impossible to add notifications in such system.

And indeed, not only it does not support position events, it does not even 
send the status updates, which are supposed to be always on.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list