[vlc-devel] [PATCH 17/17] video_output: restart display after filter change

[Alexandre Janniaux]

Hi,

On Wed, Nov 25, 2020 at 08:47:12PM +0200, Rémi Denis-Courmont wrote:
> > Changing from rectangular to 360 video
> > on the other hand is just one flag changed but may not be handled properly
> > (dunno if Vulkan handles it yet for example).
>
> The current handling of projection is half-assed. I don't know if it needs a
> source change control, a display restart or what, but it needs to be cleaned
> up regardless of this argument. A conversion filter is also necessary for those
> displays that will never support non-rectangular projections.

As a side note, OpenGL filters implementation directly addresses
this issue by providing the previous display rendering code to
all the filter chain and being able to use an arbitrary kind of
surface depending on the decoder device, thus typically allowing
to output CVPixelBuffer on iOS (keeping the same format as input)
or SurfaceTexture on Android (keeping the same format as input)
or GBM buffers.

Thus, I completely agree here. :)

Regards,
--
Alexandre Janniaux
Videolabs